Fix for old/wrong values being returned when triggered by device orientation change - #3
Open
turley wants to merge 1 commit into
Open
Fix for old/wrong values being returned when triggered by device orientation change#3turley wants to merge 1 commit into
turley wants to merge 1 commit into
Conversation
|
Don't know if it was meant to be that way- you should call ViewPort.getDimensions on the event trigger because you can still know the old screen size value. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I discovered that in some cases,
UIDeviceOrientationDidChangeNotificationis being sent before the screen'sapplicationFrameis updated, causing bad (old) dimension values to be reported to event listeners.By observing
UIApplicationDidChangeStatusBarOrientationNotificationinstead, the values forapplicationFrameappear to be more reliable in reflecting changes to the application's frame.